Review of "Simple Message" version 16

Details Page Preview

Print a custom message on the top bar.

Extension Homepage
https://github.com/freddez/gnome-shell-simple-message

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
19 Active
18 Active
17 Active
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Inactive
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
`lookupByUUID()` is a bad practice (line 78 `extension.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection). Or even better, create the gsettings instance in the entry point and just send that to the `SimpleMessage` class. Wanna fix and send it again?
fredz auto- rejected
Auto-rejected because of new version 17 was uploaded