Review of "NVIDIA GPU Stats Tool" version 13

Details Page Preview

Shows NVIDIA GPU stats in the toolbar. Requires nvidia-settings or nvidia-smi. Includes Bumblebee support.

Extension Homepage
https://github.com/ethanwharris/gnome-nvidia-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Rejected
12 Active
11 Active
10 Active
9 Rejected
8 Active
7 Active
6 Active
5 Active
4 Rejected
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Rejected because static is the same as global scope (line 10-16 `gIcons.js`). Those lines creating instance of objects in initiation: [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 2. Recommendation: `lookupByURL()` is a bad practice. You can send `this` from the entry point to the class needing it when it's possible (dependency injection).