Review of "MumblePing" version 8

Details Page Preview

Displays how many users are currently online on a mumble server

Extension Homepage
https://github.com/maweil/gnome-shell-extension-mumble-ping

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
10 Active
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active
Please change `_onDestroy()` to `destroy()` for the next version (line 214 `extension.js`).
maweil posted a review
Hi @JustPerfection, thanks for the review of version 8. As suggested, I have changed the usage of _onDestroy() to .destroy(). Sorry for the other comment/formatting changes. I changed the extension to TypeScript and changed formatting settings for prettier. I can also revert them and submit a version 10 with just that one line changed, if that helps. Then just let me know. Thank you!
JustPerfection posted a review
It's always better to have white spaces between classes and functions. Thanks!