Review of "Monitor DDC Brightness/Contrast + Extra Dimming" version 3

Details Page Preview

Control brightness and contrast with ddc and extra screen dimming with black overlay, It requires ddcutil to be installed, i2c permissions for non-root users configured.

Extension Homepage
https://github.com/tzawezin/gnome-ddc-brightness-contrast-extra-dimming

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. You should null out `displays` instead (line 189 `extension.js`). 2. Please move line 183-188 `extension.js` to the `Indicator` class instead where you create those timeouts. That way when you destroy the indicator, you will remove the timeouts too. For example, in `Indicator` class: ```js destroy() { // remove timeouts here // then call `super.destroy()`: super.destroy(); } ```