Review "Custom Command Toggle" version 1

Review of "Custom Command Toggle" version 1

Details Page Preview

Custom Command Toggle

by storageb

Run user defined terminal/shell commands and launch custom scripts using a customizable quick toggle button.

Extension Homepage: https://github.com/StorageB/custom-command-toggle

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
7	Unreviewed
6	Active
5	Rejected
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected May 23, 2024

1. Bad xml filename: [EGO Review Guidelines: GSettings Schemas](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas) 2. Please use a less generic name for the default class you are exporting (line 9 `prefs.js`). 3. Also null out in disable: ```js this._indicator = null; this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. Don't use old imports (line 27 `extension.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

storageb posted a review May 23, 2024

1. changed name of xml file to: org.gnome.shell.extensions.custom-command-toggle.gschema.xml 2. Renamed "ExamplePreferences" to "CustomCommandTogglePreferences" 3. Added the following lines to disable() this._indicator = null; this._settings = null; 4. Updated this line (now line 26) in extension.js: const {GLib, St} = imports.gi; to this: import GLib from 'gi://GLib';