Review "Kando Integration" version v0.2.0 (1)

Review of "Kando Integration" version v0.2.0 (1)

Details Page Preview

Kando Integration

by Simme

This extension is required for Kando to work on Wayland. It allows Kando to bind global shortcuts, and provides information about your currently focused application window and the position of your mouse pointer.

Extension Homepage: https://github.com/kando-menu

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
v0.4.0 (5)	Active
v0.3.1 (4)	Active
v0.3.0 (3)	Active
v0.2.1 (2)	Rejected
v0.2.0 (1)	Rejected

Previous Reviews on this Version

JustPerfection rejected June 7, 2024

1. No `this._stageConnection` (line 54 `src/Shortcuts.js`). 2. Please remove line 155-157 `extension.js`. 3. Also null out in disable: ```js this._shortcuts = null; this._inputManipulator = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. All dynamically stored memory must be cleared or freed in `disable()`: [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources)