Review of "TrainFi" version 1

Details Page Preview

Display current train trip metadata when connected to onboard Wi-Fi. Currently only supports SNCF TGV INOUI. Fetches trip data from wifi.sncf

Extension Homepage
https://github.com/altonss/trainfi

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove unnecessary files and folders: - `lint` - `.eslintrc.yml` - `.github/workflows/eslint.yml` [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Please add to the description that this extension is using wifi.sncf services. 3. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 4. Please use a less generic name for the default class you are exporting (for stack trace). 5. Also null out in disable: ```js this._label = null; this.tripDetails = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions