Review of "Network Stats" version 22

Details Page Preview

Displays internet upload speed, download speed, bandwidth, data usage. visit github page for instructions, suggestions and feature requests. ERROR while updating extension ? restart your system or reload gnome shell.

Extension Homepage
https://github.com/noroadsleft000/gnome-network-stats

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

noroadsleft posted a review
Review please.
JustPerfection rejected
1. Please don't use deprecated modules - line 1 `AppController.js` - line 4-5 `net/DeviceMonitor.js` - line 3 `net/NetworkMonitor.js` - line 11 `prefs.js` - line 1 `utils/DateTimeUtils.js` [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules) 2. No need to use `this.initTranslation()`: - line 17 `extension.js` > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 3. Also null out `GnsExtension.instance` in disable. 4. Please don't store any instance of objects in a property in the default class you are exporting (You are doing that in `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to move them to another class or make it local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 5. Gjs already has these functions (line 12 and 23 `utils/DateTimeUtils.js`). No need to implement it again. 6. Please remove `utils/GtkUtils.js`. This package is gtk4 only. 7. Please null out the instance in disable (line 10 `utils/Logger.js`).