Review of "NordVPN Quick Toggle" version 1

Details Page Preview

GNOME extension that shows a quick toggle to connect/disconnect NordVPN. This extension is not affiliated, funded, or in any way associated with NordVPN.

Extension Homepage
https://github.com/Wedaxi/NordVPN-Quick-Toggle

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 Active
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Rejected
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. `lookupByURL()` is a bad practice (line 36 `extension.js`). You have `this.path` in the entry point. 2. Also null out in disable: ```js this._indicator = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Sync spawn can freeze the GNOME Shell process (line 45 `extension.js`). Please use async instead: [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 4. Please add this to the description: > This extension is not affiliated, funded, or in any way associated with NordVPN. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions