Review "Resolution and Refresh Rate in Quick Settings" version 1

Review of "Resolution and Refresh Rate in Quick Settings" version 1

Details Page Preview

Resolution and Refresh Rate in Quick Settings

by rukins

GNOME Shell extension to add Resolution and Refresh Rate toggle menu to Quick Settings

Extension Homepage: https://github.com/rukins/quick-settings-resolution-and-refresh-rate

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected July 17, 2024

1. Also null out in disable: ```js this.monitorsConfigProxyWrapper = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. Please disconnect on disable (line 69 `extension.js`): [EGO Review Guidelines: Disconnect All Signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals) 3. Use `console.*` instead of `log()` (line 17 `fileUtils.js`): [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

rukins posted a review July 17, 2024

thank you for the review! will fix it