Review of "Resolution and Refresh Rate in Quick Settings" version 1

Details Page Preview

GNOME Shell extension to add Resolution and Refresh Rate toggle menu to Quick Settings

Extension Homepage
https://github.com/rukins/quick-settings-resolution-and-refresh-rate

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
16 Active
15 Inactive
14 Inactive
13 Inactive
12 Inactive
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Also null out in disable: ```js this.monitorsConfigProxyWrapper = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. Please disconnect on disable (line 69 `extension.js`): [EGO Review Guidelines: Disconnect All Signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals) 3. Use `console.*` instead of `log()` (line 17 `fileUtils.js`): [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
rukins posted a review
thank you for the review! will fix it