Drop-down mode for any application
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
| Version | Status |
|---|---|
| 10 | Rejected |
| 9 | Active |
| 8 | Active |
| 7 | Active |
| 6 | Inactive |
| 5 | Inactive |
| 4 | Inactive |
| 3 | Active |
| 2 | Inactive |
| 1 | Inactive |
1. Bad path and id: [EGO Review Guidelines: GSettings Schemas](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas) 2. Timeout should be removed on destroy (line 166 `quakemodeapp.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. You cannot import `Gdk` to the GNOME Shell process (line 1 `util.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 4. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 5. `lookupByURL()` is a bad practice. You can send `this` from the entry point to the class needing it when it's possible (dependency injection). - line 14 `indicator.js` - line 28 and 293 `prefs.js` - line 40 `quakemodeapp.js` 6. Extensions cannot use `run_dispose()`: - line 90 `extension.js` - line 59 `quakemodeapp.js` [EGO Review Guidelines: run_dispose](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-should-not-force-dispose-a-gobject) 7. Move to enable and null it out in disable (line 23 `extension.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 8. Extensions must not disable selectively (line 84 `extension.js`): [EGO Review Guidelines: Session Mode](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes) and `apps` should be cleared on disable no matter on which session is getting disabled. 9. Moving line 181 `extension.js` to disable is much better for readability. 10. Please move to `fillPreferencesWindow()` function: [Preferences Guide: prefs.js](https://gjs.guide/extensions/development/preferences.html#prefs-js)
quake-mode