Review "Google Search" version 1 - GNOME Shell Extensions

Review of "Google Search" version 1

Details Page Preview

Google Search

by defcat

Search google directly from GNOME. To open click on the search icon on the menu bar or enter <Super>+q. When you press enter a new tab will open in your default browser.

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
2	Active
1	Waiting for author

Previous Reviews on this Version

Meng Zhuo waiting for author March 28, 2016

I don't think use xopen is a good idea for Google search instead you can check https://extensions.gnome.org/extension/512/wikipedia-search-provider/ this out. I would accept this if you insisted

defcat (mahdi) posted a review March 31, 2016

Hi mengzhuo, thanks for your quick response. I will continue working on it as soon as im done with my exams. Then i will resubmit.

defcat (mahdi) posted a review April 12, 2016

i reviewed the code and don't think xdg-open would be a problem because the prefix for the google query is hardcoded and with the space replacement (str = str.split(' ').join('+');) i don't see the possibility of malicious input. Later i will add custom search engine functionality but for now i think its alright. Can you accept the current state?

Meng Zhuo active April 13, 2016

sure.

defcat (mahdi) waiting for author May 16, 2016

sorry for this stupid question, i just finished a new version how can i submit? I Can't find any upload button.