GNOME Shell Extensions

Review of "Generic Monitor" version 14

Details Page Preview

Generic Monitor

by soutade

Display text & icon on systray using DBUS

Extension Homepage
https://forge.soutade.fr/soutade/GnomeShellGenericMonitor
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
20 Active
19 Active
18 Active
17 Active
16 Rejected
15 Active
14 Rejected
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Rejected
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. I recommend using `destroy()` instead of `destructor()` since that's more aligned with GNOME Shell and GJS. 2. You forgot to call `this.signalManager.destructor()` on `MonitorWidget.destroy()` (line 252 `extension.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Please don't use deprecated modules (line 573 `extension.js`): [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules)