Review of "Display Adjustment" version 0.0.1 (2)

Details Page Preview

Offers sliders to control external displays' brightness and contrast through DDC. Extension requires ddcutil-service to be installed. Installation process of ddcutil-service is quick and non-intrusive. The details can be found at https://gitlab.com/w8jcik/display-adjustment#installation-of-ddcutil-service. ddcutil-service allows more responsive communication with the displays than ddcutil.

Extension Homepage
https://gitlab.com/w8jcik/display-adjustment

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
0.0.5 (8) Active
0.0.4 (7) Active
0.0.3 (6) Active
0.0.2 (5) Active
0.0.2 (4) Active
0.0.1 (3) Active
0.0.1 (2) Rejected
0.0.1 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create instance of objects in the constructor (line 24-27 `extension.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) Move those lines to enable and null them out in disable. 2. Also null out in disable: ```js this._displayConfigService = null; this._ddcutilService = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
w8jcik posted a review
Thank you for the review. Uploaded new version with the suggested change.