Review "DM Theme Changer" version 1 - GNOME Shell Extensions

Review of "DM Theme Changer" version 1

Details Page Preview

DM Theme Changer

by lynix0012

Automatically change theme styles when dark mode is enabled or disabled.

Extension Homepage: https://github.com/Lynixx01/DmThemeChanger

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
4	Active
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection rejected September 29, 2024

1. You cannot create instance of objects in the constructor (line 64 `others/darkLightSwitch.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 2. Timeout should be removed on disable: - line 146 `others/darkLightSwitch.js` - line 77, 83, 242 `extension.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. Also null out in disable: ```js optimizeTransition = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions