Review of "Spotify Controls + Track Info" version 1

Details Page Preview

GNOME 45+ extension that integrates Spotify playback controls directly into your GNOME top bar. This extension is not affiliated, funded, or in any way associated with Spotify.

Extension Homepage
https://github.com/Sonath21/spotify-controls

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Active
7 Rejected
6 Rejected
5 Active
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove unnecessary lines since you already have `this.getSettings()` in the entry point. - line 50-72 `extension.js` - line 26-43 `prefs.js` [Port Guide 45: `this.getSettings()`](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 2. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. Remove line 29 `extension.js`. not needed. 4. You cannot create instance of objects in the global scope which is the same as the constructor (line 74 `extension.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 5. You cannot connect signals in the constructor (line 434 `extension.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions