Review of "Window Desaturation" version 1

Details Page Preview

Highlight the focused window by desaturating all other windows

Extension Homepage
https://codeberg.org/mkhl/gnome-shell-extension-window-desaturation

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please don't store any instance of objects in a property in the default class you are exporting (line 8 `prefs.js`) that won't allow the garbage collector to do its job after window close. To fix that, you can attach it to the `window`: [Extensions Guide: Preferences](https://gjs.guide/extensions/development/preferences.html#prefs-js) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
mkhl posted a review
Then I suggest you change the GJS guide, I used the code from here: https://gjs.guide/extensions/development/typescript.html#prefs-ts Would it be ok to not store the GSettings instance and ave it just be a local variable?
JustPerfection posted a review
Thanks for the report. You can make it local if it's not getting garbage collected before window close.
JustPerfection posted a review
btw, you can also clean up like this: ```js window.connect('close-request', () => { // clean up here }); ```
mkhl posted a review
thanks!