Review of "RoGB" version 6

Details Page Preview

A GNOME extension to change ROGs' keyboard color.

Extension Homepage
https://github.com/Tejaromalius/RoGB

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Timeout should be removed on destroy (line 85 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)
Tejaromalius posted a review
Would this approach solve the problem: disable() { if (this._indicator) { if (this._indicator._scrollTimeoutId) { GLib.Source.remove(this._indicator._scrollTimeoutId); this._indicator._scrollTimeoutId = null; } this._indicator.destroy(); this._indicator = null; } }
JustPerfection posted a review
Do it in the same class: ```js destroy() { if (this._scrollTimeoutId) { GLib.Source.remove(this._scrollTimeoutId); } super.destroy(); } ```