1. Please remove line 9 `extension.js`, line 23 `prefs.js`. Not needed: > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you when it > sees the gettext-domain key in metadata.json. [Port Guide 45: `initTranslations()`](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 2. The default class name still using the old name (line 5 `extension.js`). 3. You cannot create instance of objects in the constructor (line 10 `extension.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) Move those lines to enable and uninit them in disable since that class is holding `settings` instance as static (line 8-9 `src/utils.js`). To call uninit in `prefs.js`: ```js window.connect('close-request', () => { // clean up here }); ``` 4. Needs cleanup on disable (line 159 `src/utils.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 5. Better to make it a function rather than modifying the prototype since that needs to be reverted on disable (line 1 `src/types.js`). 6. Timeout should be removed on destroy (line 55 and 75 `src/container.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions