Review of "Current Monitor Window/App Switcher" version 4

Details Page Preview

Includes only applications from the current monitor in the Window Switcher and App Switcher

Extension Homepage
https://github.com/thmatosbr/current-monitor-window-app-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Rejected
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
Please don't store any instance of objects in a property in the default class you are exporting (line 8 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) You can attach it to the window to avoid garbage collecting before window close: [Extensions Guide: Preferences](https://gjs.guide/extensions/development/preferences.html#prefs-js) If you don't want to move them to another class or make it local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ```
thmatosbr posted a review
Sorry, I missed that one... I'll correct it.