Review "Analog Neon Clock" version 1 - GNOME Shell Extensions

Review of "Analog Neon Clock" version 1

Details Page Preview

Analog Neon Clock

Replace digital clock with Analog Neon Clock for >3.4. Replaces the normal time/date but not the calender. Placement preference now available(except 3.8). Colors can be changed via css, for now I added color notes in the css, a preference to change themes will come soon. Todo: placement bug, Allow keeping time/date, add time to menu, color/size/thickness prefs/seconds optional. Major credit on the work of this fork goes to https://extensions.gnome.org/accounts/profile/mathematical.coffee Fork based on original work by "obneq" https://github.com/obneq/

Extension Homepage: https://github.com/l300lvl/analog-clock-gnome-shell-extension

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
9	Active
8	Active
7	Active
6	Active
5	Active
4	Rejected
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

Jasper St. Pierre posted a review January 31, 2012

> const HIDE_CLOCK = 'false'; //true to hide normal clock, false to show this clock and the normal clock Use regular booleans, not strings. > Mainloop.timeout_add_seconds(1, Lang.bind(this, function () { > Mainloop.timeout_add_seconds(1, Lang.bind(this, this._updateMenu)); You need to disconnect your timeouts on disable. Use Mainloop.source_remove. > Main.panel._leftBox.remove_actor(this.actor); Just destroy the actor instead of this whole thing: this.actor.destroy()

l300lvl posted a review February 1, 2012

> const HIDE_CLOCK = 'false'; //true to hide normal clock, false to show this clock and the normal clock Use regular booleans, not strings. Can you please give an example? > Mainloop.timeout_add_seconds(1, Lang.bind(this, function () { > Mainloop.timeout_add_seconds(1, Lang.bind(this, this._updateMenu)); You need to disconnect your timeouts on disable. Use Mainloop.source_remove. How would I do this? > Main.panel._leftBox.remove_actor(this.actor); Just destroy the actor instead of this whole thing: this.actor.destroy() I tried this, and when I try to reenable the extension it appears to be creating an empty box, and then the shell locks up and requires a reboot.

Jasper St. Pierre posted a review February 1, 2012

> Can you please give an example? const HIDE_CLOCK = false; > How would I do this? Save the identifiers that you get from Mainloop.timeout_add_seconds, and pass them to Mainloop.source_remove > I tried this, and when I try to reenable the extension it appears to be creating an empty box, and then the shell locks up and requires a reboot. Oh, you'd need to recreate the actor on enable. Yeah, OK, this way is fine.