Review of "Auto Adwaita Colors" version 2

Details Page Preview

Changes the GNOME icon theme based on the accent color

Extension Homepage
https://www.github.com/celiopy/auto-adwaita-colors

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 Active
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Rejected
6 Rejected
5 Inactive
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create instance of objects and connect signals in the constructor (line 13-15 `extension.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) Please move those lines to enable and null them out in disable. 2. Please disconnect signals on disable (line 20 `extension.js`): [EGO Review Guidelines: Disconnect all signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals) 3. Both of the instances point to the same id (line 13 and 14 `extension.js`). Only one instance would be enough. 4. Please remove line 5 `metadata.json`. That's not your extension's schema id. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions