Review "Todoit" version 1 - GNOME Shell Extensions

Review of "Todoit" version 1

Details Page Preview

Todoit

by wassimbj

Simple todo list, to keep you focused on your daily tasks

Extension Homepage: https://github.com/wassimbj/todoit-gnome

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
4	Active
3	Inactive
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection rejected November 14, 2024

1. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. `lookupByUUID()` is a bad practice (line 7 `manager.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection). 3. Also null out in disable: ```js this.button = null; this.buttonText = null; this.input = null; this.mainBox = null; this.todosBox = null; this._manager = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. You should remove the keybinding in disable (line 220 `extension.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

JustPerfection posted a review November 14, 2024

btw, we have two other extensions with the same name. Please pick another name to make it more distinctive.