Review of "Auto Accent Colour" version 5

Details Page Preview

Automatically set the GNOME accent colour based on the user's background. Note: GNOME Settings sometimes has an issue of it 'resetting' the accent colour when the Appearance page is open and the accent colour is changed externally. If this happens, navigate away from the Appearance page (or close the Settings window), and re-run the Auto Accent Colour script by clicking the 'Force Refresh' indicator option, disabling/re-enabling the extension, or locking and unlocking your device.

Extension Homepage
https://github.com/Wartybix/GNOME-Auto-Accent-Colour/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please use one of these instead of spawn command (line 242 `extension.js`): - `GLib.get_os_info('NAME')` - `GLib.get_host_name()`
JustPerfection posted a review
btw, if you are looking for Ubuntu session you can use: ```js if (Main.sessionMode.currentMode === 'ubuntu') { console.log('Running Ubuntu Session'); } ```
Wartybix posted a review
Ah okay, thank you for the tip. Your way is much nicer as well, because it means I only need to run the 'Ubuntu checker' at the start of enable(), rather than every time applyClosestAccent() is called, as it no longer needs to be in an asynchronous function like it does when using Gio.Subprocess. I'll submit a new version with the fix shortly.