Review of "RDP and SSH Connect" version 2

Details Page Preview

Connect to hosts in $HOME/.config/rd-ssh-connect/config.json file with Remmina (RDP or VNC) or SSH.

Extension Homepage
https://github.com/codavs65r/rdp-ssh-connect-noisyspoon.net

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. Please remove `stylesheet.css` since you are not using it: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 3. Remove `settings-schema` from `metadata.json`. Not needed. 4. Please move line 34-51 `extension.js` to enable and null them out in disable: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 5. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 6. Please use a less generic name for the default class you are exporting. 7. No need to use `this.initTranslation()` (line 215 `extension.js`): > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 8. Remove line 211 `extension.js` since you didn't provide any gsettings schemas and also you cannot do that in the constructor. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions