Review of "PipeWire AirPlay Toggle" version 1

Details Page Preview

Quick Setting menu toggle to enable/disable the RAOP Discover Module in PipeWire, allowing users to quickly and easily show or hide their AirPlay enabled speakers. This extension now also supports PulseAudio starting from version 8. For full details and dependency information, please review the GitHub repository wiki.

Extension Homepage
https://github.com/craw0967/pipewire-airplay-toggle

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Rejected
9 Rejected
8 Active
7 Rejected
6 Active
5 Rejected
4 Active
3 Active
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Don't use sync spawn since that can freeze the shell process (line 79 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 2. What's the reason for using line 33 `extension.js`? 3. Please use a less generic name for the default class you are exporting. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
craw0967 posted a review
Thanks for the review. I will update and resubmit. 1. This is reused code from an older attempt. I will review the relevant subprocess docs you linked and update. 2. Another holdover from old code and not understanding the spawn sync method as well as I probably should. I’ll review for need and update. 3. Whoops