Review of "pipewire-airplay-toggle" version 1

Details Page Preview

Quick setting menu toggle to enable/disable the PipeWire RAOP Discover Module (Airplay). Requires PipeWire and pipewire-zeroconf packages.

Extension Homepage
https://github.com/craw0967/pipewire-airplay-toggle

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Don't use sync spawn since that can freeze the shell process (line 79 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 2. What's the reason for using line 33 `extension.js`? 3. Please use a less generic name for the default class you are exporting. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
craw0967 posted a review
Thanks for the review. I will update and resubmit. 1. This is reused code from an older attempt. I will review the relevant subprocess docs you linked and update. 2. Another holdover from old code and not understanding the spawn sync method as well as I probably should. I’ll review for need and update. 3. Whoops