Review of "Iqair Gnome Extension" version 24

Details Page Preview

The unofficial Gnome extension for tracking air quality in real-time, using airvisual.com's IQAir service. Token apply: https://dashboard.iqair.com/personal/api-keys

Extension Homepage
https://github.com/wotmshuaisi/iqairGnomeExtension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove 48-50 from shell version. 2. Also null out in disable: ```js this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. `lookupByUUID()` is a bad practice (line 18 `extension.js`). You can send `this` from the entry point to the class needing it (dependency injection). 4. Add to the description that this extension is using `airvisual.com` services. 5. Change `_onDestroy()` (line 156 `extension.js`) to `destroy()`. Also change line 159 to `super.destroy()`. 6. Remove version from import (line 5 `extension.js`). Not needed. 7. Please don't store any instance of objects in a property in the default class you are exporting (line 10 and 17 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) Make it local to `fillPreferencesWindow()` function or you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ```