Review "NightWatcher – Nightscout CGM Monitor" version 1

Review of "NightWatcher – Nightscout CGM Monitor" version 1

Details Page Preview

NightWatcher – Nightscout CGM Monitor

by faymaz

A GNOME Shell extension for real-time Nightscout glucose monitoring, featuring customizable high/low thresholds, color-coded alerts, real-time notifications, and audible alarms for critical levels.

Extension Homepage: https://github.com/faymaz/nightwatcher

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
4	Active
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection rejected January 31, 2025

1. Bad xml filename: [EGO Review Guidelines: GSettings Schemas](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas) 2. Don't use spawn command for playing sound (line 665 `extension.js`). You can do this instead: ```js let player = global.display.get_sound_player(); let file = Gio.File.new_for_path('PATH TO THE FILE'); player.play_from_file(file, 'title', null); ``` 3. Please fix the indentations. For example, line 743 `extension.js`. 4. Timeout should be removed on destroy (line 69 and 805 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 5. Please remove `session-modes`: [EGO Review Guidelines: Metadata Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 6. There is no need for `_isEnabled` in the default class you are exporting. Also remove all of those try catch block from the default class. You should let the GNOME Shell catch in case there is any error. 7. Remove unnecessary code (for example, line 868 `extension.js`). Sending along extra code can make the review process a bit longer than it needs to be. Please double-check the package for any unnecessary code before sending it here.