A Gnome extension to run a custom command when switching night style.
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
1. Please don't store any instance of objects in a property in the default class you are exporting (line 13 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to make them local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 2. Maybe change the `_init()` function name to `_cleanup()` since you are calling it from disable function. That way it is more obvious for the reviewers. 3. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions