Review of "Ping" version 7

Details Page Preview

A Ping Extension

Extension Homepage
https://github.com/prasanthc41m/ping-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Rejected
6 Active
5 Rejected
4 Active
3 Active
2 Inactive
1 Active

Previous Reviews on this Version

JustPerfection rejected
To play sound, please use: ```js let player = global.display.get_sound_player(); let file = Gio.File.new_for_path('PATH TO THE FILE'); player.play_from_file(file, 'title', null); ``` Or play form theme: ``` player.play_from_theme('sound name', 'title', null); ```
Prasanth K posted a review
any other option?
JustPerfection posted a review
What do you mean? Doesn't the default sound player work for you?
Prasanth K posted a review
No brother, I'm trying. sound player is initializing but not playing from theme or path. I might be missing something. Let me try more debugging.
JustPerfection posted a review
That's how GNOME Shell is playing sound. For example: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/03e5d4bdd89b695e4699862cd8efe61a907aa37c/js/misc/breakManager.js#L762-764
Prasanth K posted a review
Problem was in my OS settings not in the code. After changing this - 'Settings>Sound>Alert sound>None' to other than 'none' fixed problem.