Review of "Notes With History" version 2

Details Page Preview

A cross between sticky notes and a menu full of notes 🤠.

Extension Homepage
https://github.com/grizzlysmit/notes-with-history

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use a less generic name for the default class you are exporting (line 557 `extension.js`). 2. Timeout should be removed on destroy (line 3041 `gzz.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)
grizzly@smit.id.au posted a review
OK both points taken I am away from home just now and don't have access to the latest code will fix in just over a week when I return
JustPerfection posted a review
No problem.
grizzly@smit.id.au posted a review
OK I forgot I could pull from github only problem is how do I remove a time out does this.disconnect do it the docs are not helping
grizzly@smit.id.au posted a review
JustPerfection posted a review
You can remove the timeout in the destroy (line 3025 `gzz.js`).
grizzly@smit.id.au posted a review
yes but what function removes a timeout
JustPerfection posted a review
[`GLib.Source.remove()`](https://gjs-docs.gnome.org/glib20~2.0/glib.source#function-remove) ```js if (this.time_out_id) { GLib.Source.remove(this._sourceId); } ``` You can also use `GLib.source_remove()`
grizzly@smit.id.au posted a review
thanks