Review of "Touchpad Gesture Customization" version 1

Details Page Preview

An extension which enable touchpad gestures customization in GNOME using Wayland. For full list of supported features please visit https://github.com/HieuTNg/touchpad-gesture-customization

Extension Homepage
https://github.com/HieuTNg/touchpad-gesture-customization

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use new line between functions and starting classes. It would be easier to review. 2. Please make obvious that files in `common` folder is loading on shell or `prefs.js`. Since you named the folder `common`, it is like they can be loaded in both sides. For example, you cannot import `Gtk`, `Gdk` and `Adw` in the shell process. 3. Extensions cannot use `run_dispose()`: - line 67 `src/altTab.js` - line 72 `src/snapWidnow.js` [EGO Review Guidelines: run_dispose](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-should-not-force-dispose-a-gobject) 4. `lookupByUUID()` is a bad practice (line 63 `src/animations/arrow.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection). 5. Please also remove the timeout on destroy and also before creating a new one (line 259 `src/altTab.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) If you need any help with your extension you can ask us on the: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions