Review of "Quick Settings Tweaks" version 28

Details Page Preview

Let's tweak gnome's quick settings! You can add Media Controls, Notifications, Volume Mixer on quick settings and remove useless buttons!

Extension Homepage
https://github.com/qwreey/quick-settings-tweaks

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
29 Active
28 Rejected
27 Active
26 Inactive
25 Active
24 Active
23 Active
22 Rejected
21 Rejected
20 Rejected
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Rejected
11 Rejected
10 Rejected
9 Active
8 Active
7 Active
6 Rejected
5 Inactive
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
You cannot create instance of a class in global scope (line 5 `global.js`). It should be created on enable and null out in disable: - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects)
qwreey posted a review
This is singleton class, a static object. It has dynamically stored memory, but cleared or freed when disabled, so i think that's not a matter. It follows guidelines well. Is there a way to contain a global object within extension? pass everything as parameters is kinda bad idea
JustPerfection posted a review
If you are creating a new instance in the global scope, that falls under the rules mentioned. For static properties and functions, use `static`. You don't need to use `new` in the global scope then.