Review of "sanad" version 2.1 (3)

Details Page Preview

a dns changer tool for gnome extention

Extension Homepage
https://github.com/MirS0bhan/sanad

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2.1 (4) Active
2.1 (3) Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
What DNS lists are used here? They don't appear to be publicly available. You should use gsettings and `prefs.js` so users can add their own DNS lists.
misano posted a review
this tool is customed for Iranian to pass over sanctions. there is a lot of DNS server that provide these. I would use those tool to create a settings but not for now.
JustPerfection posted a review
For the default `sanad.ns.csv` file, please use public DNS servers such as Google's 8.8.8.8 and Cloudflare's 1.1.1.1. Allow users to add their own DNS after install. Because the extension folder is removed and updated during each update, store the `sanad.ns.csv` file in the `.config` folder using [GLib.get_user_config_dir](https://gjs-docs.gnome.org/glib20~2.0/glib.get_user_config_dir) to prevent config loss.
andyholmes posted a review
I'd agree with the recommendations. Putting the file in `~/.config/<extension-uuid>/sanad.ns.csv` would allow the file to persist between installs, and you could dump the existing default into `system.ns.csv` if it doesn't exist, like the first time the extension is enabled. Then the user can switch between loading the defaults and your list of DNS servers. Alternatively, you can use GSettings which is much faster than reading from a file and isn't overwritten when the extension is updated or uninstalled.
misano posted a review
ok i go for it
misano auto- rejected
Auto-rejected because of new version 2.1 (4) was uploaded