Review of "Istighfar" version 4

Details Page Preview

get periodic istighfar reminders

Extension Homepage
https://github.com/L4z3x/Istighfar-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 Active
11 Inactive
10 Rejected
9 Rejected
8 Inactive
7 Inactive
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `preferenes` from `metadata.json`. Not needed. 2. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. Also null out in disable: ```js this.settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. Timeout should be removed on disable (line 139 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 5. Unnecessary try catch block (line 87 `extension.js`). 6. Fix the indentations: - line 172-195 `extension.js` - line 123-130 `prefs.js` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions