Review of "Toggle Between Two Display Orientations" version 1

Details Page Preview

Adds a button to toggle between Portrait and Landscape orientations. Inspired by https://github.com/shyzus/gnome-shell-extension-screen-autorotate

Extension Homepage
https://github.com/rotopenguin/gnome-toggle-two-orientations-button/

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove these files and folders: - `toggle-two-orientations@rotopenguin.net` - `stylesheet.css` - `prefs.cmb` [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. No need for line 39 `extension.js`. You can simply do: ```js this.flipIndicator?.destroy(); this.flipIndicator = null; ``` 3. Also null out in disable: ```js all_the_settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. I recommend to remove white space from the `prefs dialog.ui` file name. For example, you can use `prefs-dialog.ui` or simply `prefs.ui`. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions