Review of "ibus font setting" version 15

Details Page Preview

use ibus font setting of ibus setup dialog to enhance the user experience

Extension Homepage
https://pwu.fedorapeople.org/ibus/ibus-font-setting

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
17 Active
16 Inactive
15 Rejected
14 Rejected
13 Active
12 Inactive
11 Inactive
10 Inactive
9 Active
8 Inactive
7 Active
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
1. Move line 8 `extension.js` to enable and null that out in disable: - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. Also null out in disable: ```js this._ibusSettings = null; this._candidatePopup = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Please remove `stylesheet.css` since you are not using it: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 4. Please use `fillPreferencesWindow()` instead of `getPreferencesWidget()` (line 54 `prefs.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection posted a review
For `fillPreferencesWindow()` you can read the port guide: https://gjs.guide/extensions/upgrading/gnome-shell-42.html#fillpreferenceswindow