Review of "Quran Player" version 5

Details Page Preview

Listen to Quran recitations directly from your GNOME Shell. Features multiple reciters with audio from QuranCentral.com and Archive.org servers.

Extension Homepage
https://github.com/faymaz/quran-player

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
10 Active
9 Active
8 Rejected
7 Rejected
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Move line 505-511 `extension.js` to enable. 2. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. Please remove `_initTranslations()` function (line 1633-1656 `extension.js`). 4. Remove line 1662 `extension.js`. Not needed. 5. `this._timeoutSources` doesn't exist in the entry point (line 1734-1741 `extension.js`). 6. What's the reason for setting `LANGUAGE` env in both `extension.js` and `prefs.js`? 7. You cannot hold instance of class in the entry point property (line 621 `prefs.js`). You can clean up with: ```js window.connect('close-request', () => { // clean up here }); ``` 8. You cannot use old `imports.` in 45+ extensions. 9. You shouldn't use spawn command to open prefs (line 1045-1057 `extension.js`). You have `openPreferences()` in the entry point. 10. You shouldn't kill all of the mpv processes (line 1490 `extension.js`). Just kill the pid that you are creating. 11. This extension can be approved but I highly recommend to make it an app instead. It's easy to make it as a GJS app: [GJS Gtk Applications](https://gjs.guide/guides/)
faymaz posted a review
Thank you for reviewing my Quran Player extension. I've addressed all the issues you mentioned: 1-5. All code issues have been fixed as requested. Regarding the language environment variables: Adding multi-language support to this extension was challenging for me, and I used this approach to test and ensure proper localization. I've now improved this implementation to use GNOME Shell's built-in localization system without modifying environment variables. 7-10. These issues have been resolved as per your guidance. About making this an app instead of an extension: I created the Quran Player as a GNOME Shell extension specifically because it's currently Ramadan, and many of my friends and acquaintances wanted an easy way to listen to Quran recitations directly from their desktop environment. An extension provides convenient access from the top bar without needing to launch a separate application, which is particularly useful during this holy month. That said, I appreciate your suggestion and might consider developing it as a standalone application in the future as well. Thank you for your helpful feedback and guidance in improving this extension.