Review of "Bitahub" version 3

Details Page Preview

Display GPU information of bitahub

Extension Homepage
http://github.com/ustc-ivclab/gnome-shell-extension-bitahub

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on the same class (line 32 `extesnion.js`): ```js destroy() { GLib.Source.remove(this._updateId); } ``` In `Indicator` class hold sections in `this._sections` array and: ```js destroy() { this._sections.forEach((section) => section.destroy()); super.destroy(); } ``` Now you can remove line 129-131 `extension.js`. 2. Replace line 132 `extension.js` with: ```js this._session.abort(); ```
JustPerfection posted a review
Forgot to add `super.destroy()` to the first code block. Please add it to the end of `destroy()` function too: ```js destroy() { GLib.Source.remove(this._updateId); super.destroy(); } ```