Review of "Razer Puppy" version 1

Details Page Preview

Razer Mice battery watcher (accurate power percentage and charging status), DPI and RGB configuration extension. Also enables a user defined global hotkey to switch DPI. IMPORTANT: Requires installation of Open Razer. This extension is not affiliated, funded, or in any way associated with Razer. * Gnome tray battery power icon. Shows power status (Full / Good / Low / Sleep), charging status, power percentage next to battery icon and on hover (both can be enabled / disabled in the settings). * Displays list of plugged in Razer mice and their respective on board DPI values. * Can select a new DPI from the menu (or with global hotkey). * Settings to configure global DPI switch hotkey. This lets the user change the DPI, regardless of the active window. * If there is a device with Logo RGB, the color and light effects can be configured in the settings. * Can set a default device to display power of and a default mice to bind to DPI hotkey. Don't forget to install Open Razer https://openrazer.github.io/#download

Extension Homepage
https://github.com/ayhanavci/razerpuppy

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use a less generic name for the default class you are exporting (line 7 `extension.js`). 2. Please add this to the description: > This extension is not affiliated, funded, or in any way associated with Razer. 3. Bad xml filename: [EGO Review Guidelines: GSettings Schemas](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas) 4. Rename the `cleanup()` to `destroy()` (line 616 `indicator.js`). Then you can do `super.destroy()` at the end of that function and; then you can remove line 21 `extension.js`. 5. What's the reason for `panelIndicator` in line 16 `indicator.js`? You have the instance in `extension.js` and you can export it there if any part of your code need it. This approach is happening in other files too. Please also fix them. 6. Please move line 19 `prefs.js` to `fillPreferencesWindow()`: [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 7. You are calling `Gio.DBusProxy.new_for_bus()` for the same interface name. You can do it once in the constructor of the `RazerDbusHandler()` and then create a function for that in the same class.