Review of "Dash to Panel Menu" version 2

Details Page Preview

Dash to panel menu. Fork from Favorites Menu by cvine. https://extensions.gnome.org/extension/115/favorites-menu/

Extension Homepage
https://github.com/howbea/Dash-to-Panel-Menu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. `_settings_id` should be disconnected not destroy (line 114 `extension.js`): [EGO Review Guidelines: Disconnect all signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals) also that should be inside the `Indicator.destroy()`: ```js destroy() { if (this._settings_id) { global.settings.disconnect(this._settings_id); } super.destroy(); } ``` 3. Please use a less generic name for the default class you are exporting (line 105 `extension.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions