Review of "quick-launch" version 2

Details Page Preview

Supercharge your GNOME workflow with this sleek top-bar dock: ~ 1-Click Access - Launch apps/websites instantly ~ Full Customization - Resize icons, adjust spacing, toggle labels ~ Live Activity Indicators - Color-coded dots for running apps ~ Smart Search - Find+pin apps directly from the menu ~ 10 Keyboard Shortcuts - Instant launches with custom keybinds ~ Web Links Support - Pin frequently visited URLs ~ Auto-Start Essentials - Launch critical apps on login ~ Flexible Positioning - Left/Center/Right panel placement ~ Press-to-Reorder - Intuitive visual organization ~ Smart Limiter - Focus on what matters (max 10 items)

Extension Homepage
https://github.com/comitanigiacomo/quicklaunch

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15 Active
14 Rejected
13 Active
12 Active
11 Rejected
10 Rejected
9 Rejected
8 Inactive
7 Rejected
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Bad URL in `metadata.json`. Point to a 404 page. 2. As mentioned in the previous review you need to null out `this._settings` in disable. 3. Remove version from the imports. 4. You cannot import `Gtk` to the GNOME Shell process (line 2 `extension.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 5. What's the reason for using `Clutter.Threads.add_timeout` (line 761 `extension.js`)? 6. Move to enable and null them out in disable (line 1007-1013 `extension.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 7. You are creating many timeouts in the `extension.js` without removing them on disable or destroy: [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 8. Please keep the changes short. Only fix the issues mentioned in the review until it gets approved. Large diff makes the review process harder and longer.