Review of "Window Centering" version 1

Details Page Preview

Utilizes a shortcut to center the window on the screen and set its size to a percentage of the current screen resolution.

Extension Homepage
https://github.com/hNjJHMTr27/window-centering

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use a less generic name for the default class you are exporting: - line 24 `extension.js` - line 23 `prefs.js` 2. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 3. Please don't store any instance of objects in a property in the default class you are exporting (line 25 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) In `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Denis Golovchenko posted a review
Hello, I've got all your requirements, but I have a question. Should I change 'version' to '2' in 'metadata.json'?
JustPerfection posted a review
Hi, Yes. I suggest to keep it the same as the latest here but `version` is auto increment and it is EGO's internal. When you send an extension here, EGO automatically generate it and don't use your version.