Review of "Oxford 3000 Word Trainer" version 3

Details Page Preview

Learn English words with repetition. By default it is loaded with TR-EN words (json file), you can upload your own json file with appropriate conditions.

Extension Homepage
https://github.com/huseyincorakli/3000oxford-huseyincorakli

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Also null out in disable: ```js this._settings = null; this._tickButton.destroy(); this._tickButton = null; this._dashLabel.destroy(); this._dashLabel = null; this._englishLabel.destroy(); this._englishLabel = null; this._panelBox.destroy(); this._panelBox = null; this._vocabulary = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. On each update the extension folder will be removed. So, you will lose the `settings.json` (line 128 and 147 `extension.js`). 3. `vocabulary.json` is a very large file and you are loading it into the shell process on each enable. I can approve it like this but I highly recommend to make it an app rather than an extension. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions