Review of "Top Panel Notification Icons /w Count" version 1

Details Page Preview

Displays notifications icon in top panel

Extension Homepage
https://github.com/jiggak/notification-icons

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please don't store any instance of objects in a property in the default class you are exporting (line 10 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) It's better to keep it in `window._settings` or clean up in: ```js window.connect('close-request', () => { this._settings = null; }); ``` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions