Review of "Flickernaut" version 2

Details Page Preview

A GNOME extension that adds custom entry to Nautilus context menu. NOTE: - To use this extension, you need to install nautilus-python package. - Please restart Nautilus after enabling, disabling, or changing extension preferences to apply changes.

Extension Homepage
https://github.com/imoize/flickernaut

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Rejected
6 Active
5 Rejected
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `session-modes`: [EGO Review Guidelines: Metadata Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. You cannot leave the instance of object in global scope after disable (line 5 `lib/prefs/settings.js`).
JustPerfection posted a review
You can have `uninitSettings()` and call it in: ```js window.connect('close-request', () => { // clean up here });
brilliantnz posted a review
so i still can have (line 5 `lib/prefs/settings.js`) and clean up on window close request?
brilliantnz posted a review
lib/prefs/settings.js export function uninitSettings(): void { settings = undefined; } and call in prefs.js window.connect('close-request', () => { uninitSettings(); }); or also in extensions.js in disable() ?
JustPerfection posted a review
I don't see the `lib/prefs/settings.js` in `extension.js`. So, doing that in `prefs.js` would be enough.
brilliantnz posted a review
thanks, will do that