Review of "Task Timer" version 4

Details Page Preview

Plan your work day by timing your tasks


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Rejected
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on destroy (line 548, 558, 921 `classes/task_timer.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. You shouldn't use sleep for that and disable is async. - line 1224 `classes/task_timer.js` - line 28 `extension.js` 3. Use `console.*` instead of `log()`. If you want to do so much logs, `console.debug()` is more suited for that: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 4. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 5. Where do you use `.saveFile.json` and what is it for? 6. Why not moving everything from enable to destroy and remove `disable` (line 45 `extension.js`)? 7. Don't use deprecated modules (line 957, 968 and 991 `extension.js`): [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules)