Review of "Daily Bing Wallpaper and Accent Color" version 1.0 (1)

Details Page Preview

Simple, unobtrusive GNOME extension that automatically sets the desktop wallpaper to Bing's image of the day and optionally uses the dominant color to set the system accent color. No panel applets, no popups, no extraneous features. Works efficiently in the background without requiring user interaction. Disclaimer: "Bing" is a trademark of Microsoft Corporation. This project is not affiliated with or endorsed by Microsoft. All images remain the property of their respective copyright holders and are presumed to be intended for personal, non-commercial wallpaper use only. No images are redistributed or modified by this extension.

Extension Homepage
https://codeberg.org/haydn/dailybingwallpaper/

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.1.1 (4) Active
1.1.0 (3) Active
1.0.1 (2) Active
1.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please don't store any instance of objects in a property in the default class you are exporting (line 10 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) It's better to keep it in `window._settings` or clean up in: ```js window.connect('close-request', () => { this.#settings = null; }); ``` 2. Also `abort()` and null out `#httpSession` in disable (line 10 `extension.js`): - [Soup.Session.abort()](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects)