Review of "System HUD" version 1

Details Page Preview

Clean UI system monitor for CPU, GPU, memory, and storage._.

Extension Homepage
https://github.com/LalaloyXyz/System-info-HUD

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 Active
11 Rejected
10 Rejected
9 Rejected
8 Active
7 Inactive
6 Rejected
5 Inactive
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please don't use deprecated modules (line 9, 339 `extension.js`): [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules) 2. The default class you are exporting is pretty large and it is really hard to review for clean ups. Please move them to another class and make the default class small. 3. Don't use sync spawn since that can freeze the shell process (line 228, 236, 262, 288, 337 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) In case you only want to check whether the system is 64bit, you can use: [GLib.SIZEOF_VOID_P](https://gjs-docs.gnome.org/glib20~2.0/glib.sizeof_void_p) 8 means 64bit. 4. You should add to the description that this extension is using ipify.org services. 5. Add to the description that this extension is using iwgetid as its dependency. 6. You should remove the timeout before creating a new one since the function can be called multiple times (line 1555 `extension.js`). 7. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 8. There are so many spawn commands in this extension. Try to reduce them. We recommend to stay away from spawn commands in the shell process. The best way to reduce this is to create an app that gives you all of these info. then you can use dbus or a simple one spawn command to get all the info. That way, you reduce all the spawn commands to one and only use one dependency. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions