Drop-down mode for any application
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
Version | Status |
---|---|
1 | Rejected |
1. Bad schemas path and id: [EGO Review Guidelines: GSettings Schemas](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas). 2. You cannot disable selectively (line 84-87 `extension.js`). 3. Extensions cannot use `run_dispose()`: - line 90 `extension.js` - line 59 `quakemodeapp.js` [EGO Review Guidelines: run_dispose](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-should-not-force-dispose-a-gobject) 4. Better to call `this.injectionManager.clear()` directly in disable to improve the readability (line 181 `extension.js`). 5. Also null out in disable: ```js this.injectionManager.clear(); this.injectionManager = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 6. Move line 23 `extension.js` to enable: - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 7. Please use `fillPreferencesWindow()` instead of `getPreferencesWidget()`: [Port Guide 42: fillpreferenceswindow](https://gjs.guide/extensions/upgrading/gnome-shell-42.html#fillpreferenceswindow) 8. `lookupByURL()` is a bad practice (line 40 `quakemodeapp.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection). 9. Timeout should be removed on destroy (line 166 `quakemodeapp.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 10. You cannot import `Gtk` to the GNOME Shell process (line 1 `util.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
11. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging)